-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rotation option to both detection training scripts #765
Conversation
Codecov Report
@@ Coverage Diff @@
## main #765 +/- ##
==========================================
- Coverage 96.00% 95.95% -0.05%
==========================================
Files 129 129
Lines 4807 4824 +17
==========================================
+ Hits 4615 4629 +14
- Misses 192 195 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I raised a concern about the optimal order of transforms, cf my comments 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
Isn't that gorgeous 😄 |
I think for the train set it is OK, because if we don't rotate we don't want to use polygons and if we rotate we don't need polygons in the constructor because polygons are created in get_item when rotating boxes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
This PR adds the ability to train with rotated samples, by simply passing --rotation as an argument of the CLI detection training scripts.
The default rotation transformation performed on your training set is +-90°, and no rotation on the validation set, but this can be easily modified.
Here is how it renders for a batch of training samples:
Any feedback is welcome!