-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added WordGenerator dataset #760
Conversation
Codecov Report
@@ Coverage Diff @@
## main #760 +/- ##
==========================================
- Coverage 96.22% 96.05% -0.17%
==========================================
Files 129 129
Lines 4764 4794 +30
==========================================
+ Hits 4584 4605 +21
- Misses 180 189 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, indeed we need to find a way to filter out characters that cannot be rendered, an option could be to cast them with unidecode
This PR introduces the following modifications:
WordGenerator
in the same spirit as theCharGenerator
using amin_chars
andmax_chars
to specify the word length.To illustrate the PR, the following snippet:
produces:
And the same in
font_size=64
:Finally, the dataset itself:
renders as follows:
(Easily turned into something more appealing with transformations like ColorInversion, etc.)
Please note that some characters such as bitcoin symbol are not properly rendered silently, this will have to be investigated
Closes #262