-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rotated ckpts for pytorch DBNet + fix line resolution for rotated pages #743
Conversation
Codecov Report
@@ Coverage Diff @@
## main #743 +/- ##
==========================================
- Coverage 96.19% 96.10% -0.09%
==========================================
Files 129 129
Lines 4810 4805 -5
==========================================
- Hits 4627 4618 -9
- Misses 183 187 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Minor improvement suggestions in the review 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, only minor changes left! Still some CI jobs failing though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank a lot for all this work!
This PR adds rotated ckpts in the db_resnet50 cfg in torch, and fixes the document builder:
to be merged after #731
Any feedback is welcome!