-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVHN dataset integration #634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Felix! I added a few suggestions, including switching to scipy
411aacf
to
c718eae
Compare
Codecov Report
@@ Coverage Diff @@
## main #634 +/- ##
==========================================
+ Coverage 96.20% 96.34% +0.13%
==========================================
Files 124 125 +1
Lines 4668 4707 +39
==========================================
+ Hits 4491 4535 +44
+ Misses 177 172 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I added a snippet to replace the data unpacking part 👍
9f0ba78
to
ad67eea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#694 is merged 👍
I realized SVHN is processing train & test sets exactly the same way, so no need for the extra test case!
e0e7d52
to
da4ce3f
Compare
da4ce3f
to
273598f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's some neat monkeypatching 👍
Thanks a lot!
This PR integrates the SVHN dataset for digit localization
#587
Any suggestions are very welcome 🤗