Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adds missing console log and removed Tensorboard #626

Merged
merged 3 commits into from
Nov 15, 2021
Merged

Conversation

fg-mindee
Copy link
Contributor

This PR introduces the following modifications:

  • adds missing console log of validation metrics in the detection training
  • removes support of Tensorboard

Any feedback is welcome!

@fg-mindee fg-mindee added type: enhancement Improvement ext: references Related to references folder labels Nov 15, 2021
@fg-mindee fg-mindee added this to the 0.4.1 milestone Nov 15, 2021
@fg-mindee fg-mindee self-assigned this Nov 15, 2021
@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #626 (9d42cd8) into main (2a4e2b4) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #626      +/-   ##
==========================================
- Coverage   96.18%   96.16%   -0.03%     
==========================================
  Files         111      111              
  Lines        4300     4300              
==========================================
- Hits         4136     4135       -1     
- Misses        164      165       +1     
Flag Coverage Δ
unittests 96.16% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dels/detection/differentiable_binarization/base.py 91.19% <0.00%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a4e2b4...9d42cd8. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@fg-mindee fg-mindee merged commit f8f6d3e into main Nov 15, 2021
@fg-mindee fg-mindee deleted the train-log branch November 15, 2021 17:24
@@ -11,8 +11,6 @@
import datetime
import hashlib
import time
from collections import deque
from pathlib import Path

import numpy as np
import tensorflow as tf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be we also have to import wandb in the script?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it is on line19 ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: references Related to references folder type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants