Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fixed README instruction for page synthesis #590

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Conversation

fg-mindee
Copy link
Contributor

This PR updates the instructions for page synthesis in the README that were failing.

Any feedback is welcome!

@fg-mindee fg-mindee added the topic: documentation Improvements or additions to documentation label Nov 8, 2021
@fg-mindee fg-mindee added this to the 0.4.1 milestone Nov 8, 2021
@fg-mindee fg-mindee self-assigned this Nov 8, 2021
@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #590 (1edb5f9) into main (f537551) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #590   +/-   ##
=======================================
  Coverage   96.03%   96.03%           
=======================================
  Files         110      110           
  Lines        4264     4264           
=======================================
  Hits         4095     4095           
  Misses        169      169           
Flag Coverage Δ
unittests 96.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f537551...1edb5f9. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fg-mindee fg-mindee merged commit 0064a9b into main Nov 9, 2021
@fg-mindee fg-mindee deleted the readme-fix branch November 9, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants