-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IIIT-5K dataset integration #589
Conversation
Hi there 👋 Considering IIIT-5K is available publicly, let's use the public URL rather than reuploading it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Felix! I added a few comments, let me know what you think 👌
Codecov Report
@@ Coverage Diff @@
## main #589 +/- ##
==========================================
+ Coverage 96.03% 96.15% +0.12%
==========================================
Files 110 111 +1
Lines 4265 4296 +31
==========================================
+ Hits 4096 4131 +35
+ Misses 169 165 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the edits! I suggest reverting the changes about the target_task
and this will apply to all datasets and is not related to this PR goal directly :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some last suggestions and we're good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks a lot @felixdittrich92 🙏
This PR integrates the IIIT-5K dataset recognition part
TODO:
upload dataset:
TRAIN
TEST
@fg-mindee
Can you add both and send me SHA and URL ?
Issues:
#587