Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added DocArtefacts dataset #583

Merged
merged 11 commits into from
Nov 5, 2021
Merged

feat: added DocArtefacts dataset #583

merged 11 commits into from
Nov 5, 2021

Conversation

SiddhantBahuguna
Copy link
Contributor

This PR introduces the following modifications:

  • Implemented class wrapper for artefact detection dataset

Any feedback is welcome!

@SiddhantBahuguna SiddhantBahuguna added type: enhancement Improvement module: datasets Related to doctr.datasets labels Nov 4, 2021
@SiddhantBahuguna SiddhantBahuguna self-assigned this Nov 4, 2021
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks to me like we're missing two things:

  • Added the corresponding entry in the documentation
  • Adding corresponding unittest

@fg-mindee fg-mindee added this to the 0.5.0 milestone Nov 4, 2021
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #583 (058138a) into main (c882689) will decrease coverage by 0.06%.
The diff coverage is 93.54%.

❗ Current head 058138a differs from pull request most recent head 72f54db. Consider uploading reports for the commit 72f54db to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
- Coverage   96.05%   95.98%   -0.07%     
==========================================
  Files         109      110       +1     
  Lines        4233     4264      +31     
==========================================
+ Hits         4066     4093      +27     
- Misses        167      171       +4     
Flag Coverage Δ
unittests 95.98% <93.54%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/datasets/doc_artefacts.py 93.33% <93.33%> (ø)
doctr/datasets/__init__.py 100.00% <100.00%> (ø)
doctr/datasets/funsd.py 93.75% <0.00%> (-3.13%) ⬇️
doctr/datasets/sroie.py 92.30% <0.00%> (-2.57%) ⬇️
doctr/datasets/cord.py 95.00% <0.00%> (-2.50%) ⬇️
...dels/detection/differentiable_binarization/base.py 91.82% <0.00%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c882689...72f54db. Read the comment docs.

Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fg-mindee fg-mindee merged commit f537551 into main Nov 5, 2021
@fg-mindee fg-mindee deleted the artefact_detection branch November 5, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: datasets Related to doctr.datasets type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants