-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added DocArtefacts dataset #583
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Looks to me like we're missing two things:
- Added the corresponding entry in the documentation
- Adding corresponding unittest
Codecov Report
@@ Coverage Diff @@
## main #583 +/- ##
==========================================
- Coverage 96.05% 95.98% -0.07%
==========================================
Files 109 110 +1
Lines 4233 4264 +31
==========================================
+ Hits 4066 4093 +27
- Misses 167 171 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR introduces the following modifications:
Any feedback is welcome!