fix: Fixed support of characters out of latin-1 in page synthesis #496
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the page synthesis feature. Up until now, we have relied on the support of text drawing using Pillow. However as pointed out by #495, this support is limited.
This snippet crashes:
this PR changes this by catching the
UnicodeEncodeError
and normalizing the string as follows:Please note that in doing so, some string will be synthesized with different length cf the snippet below:
Closes #495
Any feedback is welcome!