-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc fixed to Streamlit demo #492
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the demo & the bug fix @osanseviero 🙏
To answer your questions:
- we have an upcoming release in a few days so the page synthesis will be on a stable release!
- you're correct about the package ref in the demo, but for the same reason than your first point, I think it might be best to stay aligned with the main branch on Github, don't you think?
I added a comment to use the extras to have a fully compatible TF environment, let me know what you think!
Codecov Report
@@ Coverage Diff @@
## main #492 +/- ##
=======================================
Coverage 94.99% 94.99%
=======================================
Files 108 108
Lines 4177 4177
=======================================
Hits 3968 3968
Misses 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Thanks for your input! I changed the requirements as you suggested and removed the TF requirements since they are part of the extras. I'm glad you liked the demo! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much appreciated Omar!
@osanseviero by any chance, is there a markdown badge or something similar for huggingface spaces demo? |
For reference: cf #426 |
As suggested in mindee#492 (comment)
As suggested in #492 (comment)
Hello!
I built a Space demo hosting your Streamlit example (link at https://huggingface.co/spaces/osanseviero/doctr). It works great and is much faster than I expected.
I did face some issues during the development. I hope this PR fixes them:
doctr
in therequirements
but I think that's actually an unrelated package, it should bepython-doctr
.out.pages[0].synthesize()
threw an error sayingPage
class has nosynthesize
method. This was introduced in feat: Improved font resolution and page synthesis #472 so I don't think it's in the recent release.Given 1 and 2, and that #472 will probably be soon in a release, maybe we could change
requirements.txt
to installpython-doctr[tf]
instead of installing directly from GitHub. WDYT?