-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Refactored API of doctr.models #481
Conversation
Split Predictor objects into framework-specific implementations
Codecov Report
@@ Coverage Diff @@
## main #481 +/- ##
==========================================
- Coverage 95.42% 94.97% -0.45%
==========================================
Files 97 108 +11
Lines 4065 4160 +95
==========================================
+ Hits 3879 3951 +72
- Misses 186 209 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR introduces the following modifications:
__init__
files ofdoctr.models
to keep only the relevant modules accessible (private modules that will see their API change in the future are better left out of this)DocumentBuilder
fromdoctr/models/core.py
todoctr/models/builder.py
DetectionModel
andRecognitionModel
intoBaseModel
doctr/models/recognition/core.py
todoctr/models/recognition/base.py
Any feedback is welcome!