-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: performances update following up the crop splitting feature #471
Conversation
Codecov Report
@@ Coverage Diff @@
## main #471 +/- ##
==========================================
- Coverage 95.79% 95.76% -0.03%
==========================================
Files 95 95
Lines 3992 3992
==========================================
- Hits 3824 3823 -1
- Misses 168 169 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
This PR adds the benchmark of all models with the new crop splitting feature activated, for some datasets it changes almost nothing, but for our private datasets (especially IDS with a lot of MRZ) it improves significantly performances and beyond that results are far more consistent when dealing with extremely long sequences, even if the exact match metric does not always reflect that (one small mistake over 45 chars is better than 45 mistakes...).
Any feedback is welcome!