-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ tqdm slack #1837
feat: ✨ tqdm slack #1837
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1837 +/- ##
==========================================
- Coverage 96.59% 96.56% -0.04%
==========================================
Files 165 165
Lines 7940 7940
==========================================
- Hits 7670 7667 -3
- Misses 270 273 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @odulcy-mindee 🤗
Could we add a quick note to each README in the references how to setup (maybe slack reference link) and that both values needs to be set as env ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks :)
Usage of
tqdm slack
is explained here. You only need to set environment variables, no need to pass token and channel in args.