Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[references] Unify sched + optim config and add AdamW as option #1825

Merged
merged 5 commits into from
Dec 20, 2024
Merged

[references] Unify sched + optim config and add AdamW as option #1825

merged 5 commits into from
Dec 20, 2024

Conversation

felixdittrich92
Copy link
Contributor

This PR:

  • Unify sched and optim config between train scripts
  • Add AdamW as option

Any feedback is welcome 🤗

@felixdittrich92 felixdittrich92 added type: enhancement Improvement ext: references Related to references folder framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend topic: text detection Related to the task of text detection topic: text recognition Related to the task of text recognition topic: character classification Related to the task of character classification labels Dec 20, 2024
@felixdittrich92 felixdittrich92 added this to the 0.11.0 milestone Dec 20, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.58%. Comparing base (0e06eae) to head (d83beca).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1825      +/-   ##
==========================================
- Coverage   96.59%   96.58%   -0.02%     
==========================================
  Files         165      165              
  Lines        7939     7939              
==========================================
- Hits         7669     7668       -1     
- Misses        270      271       +1
Flag Coverage Δ
unittests 96.58% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixdittrich92 felixdittrich92 merged commit e6bf82d into mindee:main Dec 20, 2024
68 of 69 checks passed
@felixdittrich92 felixdittrich92 deleted the adamw-addition branch December 20, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odulcy-mindee odulcy-mindee odulcy-mindee approved these changes

Assignees
No one assigned
Labels
ext: references Related to references folder framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend topic: character classification Related to the task of character classification topic: text detection Related to the task of text detection topic: text recognition Related to the task of text recognition type: enhancement Improvement
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@felixdittrich92 @odulcy-mindee