Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] fix straighten pages #1697

Merged
merged 1 commit into from
Aug 26, 2024
Merged

[Bug] fix straighten pages #1697

merged 1 commit into from
Aug 26, 2024

Conversation

felixdittrich92
Copy link
Contributor

This PR:

  • fix rotate condition for straighten pages
  • fix new shapes after straightening pages
  • ruff recommendations

Any feedback is welcome 🤗

@felixdittrich92 felixdittrich92 added type: bug Something isn't working module: models Related to doctr.models topic: text detection Related to the task of text detection labels Aug 19, 2024
@felixdittrich92 felixdittrich92 added this to the 0.9.1 milestone Aug 19, 2024
@felixdittrich92 felixdittrich92 linked an issue Aug 19, 2024 that may be closed by this pull request
result.show() not displaying bounding boxes correctly #1691
Closed
@felixdittrich92 felixdittrich92 marked this pull request as ready for review August 19, 2024 08:02
@codecov Codecov
Copy link

codecov bot commented Aug 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.43%. Comparing base (d7f4533) to head (1a8b82a).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1697      +/-   ##
==========================================
+ Coverage   96.38%   96.43%   +0.05%     
==========================================
  Files         164      164              
  Lines        7772     7776       +4     
==========================================
+ Hits         7491     7499       +8     
+ Misses        281      277       -4
Flag Coverage Δ
unittests 96.43% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixdittrich92 felixdittrich92 self-assigned this Aug 19, 2024
odulcy-mindee
odulcy-mindee approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@odulcy-mindee odulcy-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you !

@felixdittrich92
Copy link
Contributor Author

LGTM, thank you !

WB 😊

@felixdittrich92 felixdittrich92 merged commit 4434213 into mindee:main Aug 26, 2024
81 checks passed
@felixdittrich92 felixdittrich92 deleted the fix-straighten branch August 26, 2024 08:54
@odulcy-mindee
Copy link
Collaborator

Haha, thanks ^^

@felixT2K felixT2K mentioned this pull request Aug 27, 2024
Closed
@felixdittrich92
Copy link
Contributor Author

@odulcy-mindee Could you check your Slack please if you have the time 😅 : 👍

@felixdittrich92 felixdittrich92 modified the milestones: 0.9.1, 0.10.0 Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odulcy-mindee odulcy-mindee odulcy-mindee approved these changes

Assignees

@felixdittrich92 felixdittrich92

Labels
module: models Related to doctr.models topic: text detection Related to the task of text detection type: bug Something isn't working
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

result.show() not displaying bounding boxes correctly
2 participants
@felixdittrich92 @odulcy-mindee