Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datasets] Update vocabs.py by hindi chars #1618

Closed
wants to merge 1 commit into from
Closed

[Datasets] Update vocabs.py by hindi chars #1618

wants to merge 1 commit into from

Conversation

chaudhary-mohit
Copy link

@chaudhary-mohit chaudhary-mohit commented May 30, 2024 •
edited by felixdittrich92
Loading

This PR:

  • add hindi to vocabs
  • update corresponding documentation vocab table

felixdittrich92
felixdittrich92 requested changes May 30, 2024
View reviewed changes
Copy link
Contributor

@felixdittrich92 felixdittrich92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chaudhary-mohit 👋,

Thanks for your PR 👍

Could you please update also the docs vocabs table in : https://github.com/mindee/doctr/blob/main/docs/source/modules/datasets.rst

afterwards please run

make style

doctr/datasets/vocabs.py
@@ -66,6 +67,7 @@
+ VOCABS["danish"]
+ VOCABS["finnish"]
+ VOCABS["swedish"]
+ VOCABS["hindi"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove this for the moment because as you can see it contains only european characters and we don't have a dataset which includes hindi yet :)

@felixdittrich92 felixdittrich92 self-assigned this May 30, 2024
@felixdittrich92 felixdittrich92 changed the title Update vocabs.py by hindi chars [Datasets] Update vocabs.py by hindi chars May 30, 2024
@felixdittrich92 felixdittrich92 added this to the 0.9.0 milestone May 30, 2024
@felixdittrich92 felixdittrich92 added topic: documentation Improvements or additions to documentation type: enhancement Improvement module: datasets Related to doctr.datasets ext: docs Related to docs folder labels May 30, 2024
@felixdittrich92 felixdittrich92 linked an issue May 30, 2024 that may be closed by this pull request
Hindi Language support #1617
Closed
@felixdittrich92 felixdittrich92 marked this pull request as draft May 31, 2024 13:53
@felixdittrich92
Copy link
Contributor

any updates @chaudhary-mohit ? :)

@felixT2K felixT2K mentioned this pull request Aug 8, 2024
Merged
@felixdittrich92
Copy link
Contributor

Closed by #1687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixdittrich92 felixdittrich92 felixdittrich92 requested changes

Assignees

@felixdittrich92 felixdittrich92

Labels
ext: docs Related to docs folder module: datasets Related to doctr.datasets topic: documentation Improvements or additions to documentation type: enhancement Improvement
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

Hindi Language support
2 participants
@chaudhary-mohit @felixdittrich92