Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TF] add fast models and benchmarks #1583

Merged
merged 5 commits into from
May 6, 2024

Conversation

felixdittrich92
Copy link
Contributor

This PR:

  • Add pytorch converted fast models

@odulcy-mindee please upload the models :)

@felixdittrich92 felixdittrich92 added topic: documentation Improvements or additions to documentation type: enhancement Improvement module: models Related to doctr.models benchmark This issue reports a benchmark framework: tensorflow Related to TensorFlow backend topic: text detection Related to the task of text detection ext: docs Related to docs folder labels May 4, 2024
@felixdittrich92 felixdittrich92 added this to the 0.9.0 milestone May 4, 2024
@felixdittrich92 felixdittrich92 self-assigned this May 4, 2024
Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.36%. Comparing base (2940d9d) to head (a5f4834).
Report is 2 commits behind head on main.

❗ Current head a5f4834 differs from pull request most recent head 65e7888. Consider uploading reports for the commit 65e7888 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1583      +/-   ##
==========================================
+ Coverage   96.35%   96.36%   +0.01%     
==========================================
  Files         163      163              
  Lines        7701     7702       +1     
==========================================
+ Hits         7420     7422       +2     
+ Misses        281      280       -1     
Flag Coverage Δ
unittests 96.36% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

odulcy-mindee
odulcy-mindee previously approved these changes May 6, 2024
Copy link
Collaborator

@odulcy-mindee odulcy-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳
That's so cool ! Thank you !!

doctr/models/detection/fast/tensorflow.py Outdated Show resolved Hide resolved
doctr/models/detection/fast/tensorflow.py Outdated Show resolved Hide resolved
doctr/models/detection/fast/tensorflow.py Outdated Show resolved Hide resolved
Co-authored-by: Olivier Dulcy <106678676+odulcy-mindee@users.noreply.github.com>
felixdittrich92 and others added 2 commits May 6, 2024 17:54
Co-authored-by: Olivier Dulcy <106678676+odulcy-mindee@users.noreply.github.com>
Co-authored-by: Olivier Dulcy <106678676+odulcy-mindee@users.noreply.github.com>
@odulcy-mindee odulcy-mindee merged commit bf82d63 into mindee:main May 6, 2024
72 of 78 checks passed
@felixdittrich92 felixdittrich92 deleted the fast-tf-models branch August 30, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark This issue reports a benchmark ext: docs Related to docs folder framework: tensorflow Related to TensorFlow backend module: models Related to doctr.models topic: documentation Improvements or additions to documentation topic: text detection Related to the task of text detection type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants