-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace unidecode with text-unidecode. #1509
Replace unidecode with text-unidecode. #1509
Conversation
Hi @jonatankawalek 👋, Thanks for the PR i agree with the license mismatch, but |
Hi @felixdittrich92, You're right - text-unidecode seems stale. Anyascii looks to be a better choice. Let me replace it with that. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1509 +/- ##
==========================================
+ Coverage 95.81% 95.82% +0.01%
==========================================
Files 166 166
Lines 7646 7646
==========================================
+ Hits 7326 7327 +1
+ Misses 320 319 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@jonatankawalek
And run See: |
Ran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and replacement 👍
This PR addresses "Unidecode has a problematic OSS license #1508".