Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unidecode with text-unidecode. #1509

Conversation

jonatankawalek
Copy link
Contributor

This PR addresses "Unidecode has a problematic OSS license #1508".

@felixdittrich92
Copy link
Contributor

Hi @jonatankawalek 👋,

Thanks for the PR i agree with the license mismatch, but text-unidecode seems not to get any updates anymore. Maybe https://github.com/anyascii/anyascii is a better alternative wdyt ?

@jonatankawalek
Copy link
Contributor Author

Hi @felixdittrich92,

You're right - text-unidecode seems stale. Anyascii looks to be a better choice. Let me replace it with that.

@felixdittrich92 felixdittrich92 linked an issue Mar 12, 2024 that may be closed by this pull request
@felixdittrich92 felixdittrich92 added this to the 0.9.0 milestone Mar 12, 2024
@felixdittrich92 felixdittrich92 self-assigned this Mar 12, 2024
@felixdittrich92 felixdittrich92 added topic: build Related to dependencies and build module: utils Related to doctr.utils type: misc Miscellaneous labels Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 95.82%. Comparing base (60d4005) to head (15b35ea).

Files Patch % Lines
doctr/utils/visualization.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1509      +/-   ##
==========================================
+ Coverage   95.81%   95.82%   +0.01%     
==========================================
  Files         166      166              
  Lines        7646     7646              
==========================================
+ Hits         7326     7327       +1     
+ Misses        320      319       -1     
Flag Coverage Δ
unittests 95.82% <84.61%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixdittrich92
Copy link
Contributor

felixdittrich92 commented Mar 12, 2024

@jonatankawalek
Please add anyascii.* to
pyprojet.toml L147

[[tool.mypy.overrides]]
module = [

And run make style afterwards to fix formating issues :)
You can use make quality to check that all typings are correct from your code changes (If there is listed something you haven't changed ignore it)

See:
https://github.com/mindee/doctr/actions/runs/8248587881/job/22560038000?pr=1509

@jonatankawalek
Copy link
Contributor Author

jonatankawalek commented Mar 12, 2024

@felixdittrich92

Ran make style and fixed flags for my code chages (there were other style issues too, but not to do with my changes).
make quality doesn't flag anything for my code changes

pyproject.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@felixdittrich92 felixdittrich92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and replacement 👍

@felixdittrich92 felixdittrich92 merged commit 709404e into mindee:main Mar 12, 2024
69 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: utils Related to doctr.utils topic: build Related to dependencies and build type: misc Miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unidecode has a problematic OSS license
2 participants