[tests/bug] improve tests and fix a minor bug #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixdittrich92
added
type: enhancement
Codecov Report
@@ Coverage Diff @@
## main #1229 +/- ##
=======================================
Coverage ? 95.65%
=======================================
Files ? 154
Lines ? 6876
Branches ? 0
=======================================
Hits ? 6577
Misses ? 299
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
|
felixdittrich92
changed the title
odulcy-mindee
requested changes
Jun 26, 2023
felixdittrich92
commented
Jun 27, 2023
| import doctr | ||
|
|
||
|
|
||
| def test_version(): | ||
| assert len(doctr.__version__.split(".")) == 3 | ||
|
|
||
|
|
||
| @pytest.mark.skipif(doctr.is_torch_available() and doctr.is_tf_available(), reason="torch and tf are available") |
There was a problem hiding this comment.
@odulcy-mindee this is better it skips the tests (make tests works now also if both backends installed if you develop on doctr) and does not effect the CI jobs
There was a problem hiding this comment.
Oh yeah, that's even better
odulcy-mindee
approved these changes
Jun 27, 2023
Comment on lines
+19
to
+30
| ["db_resnet34", (3, 512, 512), (1, 512, 512), True, True], | ||
| ["db_resnet34", (3, 512, 512), (1, 512, 512), True, False], | ||
| ["db_resnet50", (3, 512, 512), (1, 512, 512), True, True], | ||
| ["db_resnet50", (3, 512, 512), (1, 512, 512), True, False], | ||
| ["db_mobilenet_v3_large", (3, 512, 512), (1, 512, 512), True, True], | ||
| ["db_mobilenet_v3_large", (3, 512, 512), (1, 512, 512), True, False], | ||
| ["linknet_resnet18", (3, 512, 512), (1, 512, 512), True, True], | ||
| ["linknet_resnet18", (3, 512, 512), (1, 512, 512), True, False], | ||
| ["linknet_resnet34", (3, 512, 512), (1, 512, 512), True, True], | ||
| ["linknet_resnet34", (3, 512, 512), (1, 512, 512), True, False], | ||
| ["linknet_resnet50", (3, 512, 512), (1, 512, 512), True, True], | ||
| ["linknet_resnet50", (3, 512, 512), (1, 512, 512), True, False], |
There was a problem hiding this comment.
I just discovered we can stack parametrize parameter from documentation (quite useful for train_mode argument):
import pytest
@pytest.mark.parametrize("x", [0, 1])
@pytest.mark.parametrize("y", [2, 3])
def test_foo(x, y):
passWe can keep it like that for this PR, that's fine 👍
There was a problem hiding this comment.
Ah nice good to know 👍
Yes, I also think that we can slim it down in another PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
merge_strings->doctr/models/recognition/utils.pyfile_utils.pyandhub.pybecause we cannot test some cases or it is already tested by third party lib (e.g.: hf hub)