Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] PARSeq tensorflow fixes #1228

Merged
merged 7 commits into from
Jun 23, 2023

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented Jun 22, 2023

This PR:

  • several fixes

  • test run

torch fail will be fixed if #1227 is merged

Validation set loaded in 0.002758s (2520 samples in 79 batches)
Train set loaded in 0.003837s (126000 samples in 3937 batches)
Validation loss decreased inf --> 4.64792: saving state...
Epoch 1/20 - Validation loss: 4.64792 (Exact: 0.08% | Partial: 0.08%)
Validation loss decreased 4.64792 --> 4.37974: saving state...
Epoch 2/20 - Validation loss: 4.37974 (Exact: 0.48% | Partial: 0.91%)
Validation loss decreased 4.37974 --> 4.3734: saving state...
Epoch 3/20 - Validation loss: 4.3734 (Exact: 0.99% | Partial: 1.39%)
Validation loss decreased 4.3734 --> 4.32947: saving state...
Epoch 4/20 - Validation loss: 4.32947 (Exact: 2.14% | Partial: 3.10%)

@felixdittrich92 felixdittrich92 added type: bug Something isn't working module: models Related to doctr.models framework: tensorflow Related to TensorFlow backend labels Jun 22, 2023
@felixdittrich92 felixdittrich92 added this to the 0.6.1 milestone Jun 22, 2023
@felixdittrich92 felixdittrich92 self-assigned this Jun 22, 2023
@felixdittrich92 felixdittrich92 marked this pull request as ready for review June 23, 2023 06:38
Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just one point to clarify

doctr/models/recognition/parseq/tensorflow.py Show resolved Hide resolved
charlesmindee
charlesmindee previously approved these changes Jun 23, 2023
Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, LGTM

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #1228 (c19eb9b) into main (b4b613a) will decrease coverage by 0.23%.
The diff coverage is 60.37%.

@@            Coverage Diff             @@
##             main    #1228      +/-   ##
==========================================
- Coverage   93.55%   93.32%   -0.23%     
==========================================
  Files         154      154              
  Lines        6915     6924       +9     
==========================================
- Hits         6469     6462       -7     
- Misses        446      462      +16     
Flag Coverage Δ
unittests 93.32% <60.37%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/recognition/parseq/tensorflow.py 71.11% <60.37%> (-5.75%) ⬇️

... and 1 file with indirect coverage changes

@felixdittrich92 felixdittrich92 merged commit 61a32a1 into mindee:main Jun 23, 2023
@felixdittrich92 felixdittrich92 deleted the parseq-tf-fixes branch June 23, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework: tensorflow Related to TensorFlow backend module: models Related to doctr.models type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants