Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Error in unpacking archive of CORD dataset #1190

Merged
merged 2 commits into from
May 1, 2023
Merged

[FIX] Error in unpacking archive of CORD dataset #1190

merged 2 commits into from
May 1, 2023

Conversation

HamzaGbada
Copy link
Contributor

Fixing the unpacking archive of CORD dataset.

@codecov
Copy link

codecov bot commented Apr 30, 2023 •
edited
Loading

Codecov Report

Merging #1190 (4bea0da) into main (495c84c) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1190      +/-   ##
==========================================
- Coverage   95.01%   94.99%   -0.02%     
==========================================
  Files         149      149              
  Lines        6417     6417              
==========================================
- Hits         6097     6096       -1     
- Misses        320      321       +1
Flag Coverage Δ
unittests 94.99% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/datasets/cord.py 97.72% <100.00%> (ø)

... and 2 files with indirect coverage changes

@felixdittrich92
Copy link
Contributor

felixdittrich92 commented Apr 30, 2023 •
edited
Loading

Hey @HamzaGbada 👋 ,
Thanks a lot :)

Could you please run make style to fix the failing black test 👍

You can also check the failing test details to see what is going wrong: https://github.com/mindee/doctr/actions/runs/4846085256/jobs/8635397480?pr=1190

@felixdittrich92 felixdittrich92 self-assigned this Apr 30, 2023
@felixdittrich92 felixdittrich92 added type: bug Something isn't working ext: tests Related to tests folder module: datasets Related to doctr.datasets labels Apr 30, 2023
@felixdittrich92 felixdittrich92 added this to the 0.6.1 milestone Apr 30, 2023
@felixdittrich92 felixdittrich92 linked an issue Apr 30, 2023 that may be closed by this pull request
[datasets] Error in unpacking archive of CORD dataset #1189
Closed
felixdittrich92
felixdittrich92 approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@felixdittrich92 felixdittrich92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix :)

@felixdittrich92 felixdittrich92 merged commit 2204a61 into mindee:main May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixdittrich92 felixdittrich92 felixdittrich92 approved these changes

Assignees

@felixdittrich92 felixdittrich92

Labels
ext: tests Related to tests folder module: datasets Related to doctr.datasets type: bug Something isn't working
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

[datasets] Error in unpacking archive of CORD dataset
2 participants
@HamzaGbada @felixdittrich92