Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make pretrained backbone flexible in predictor #1061

Merged
merged 3 commits into from
Sep 19, 2022
Merged

make pretrained backbone flexible in predictor #1061

merged 3 commits into from
Sep 19, 2022

Conversation

felixdittrich92
Copy link
Contributor

This PR:

Any feedback is welcome 🤗

@felixdittrich92 felixdittrich92 added module: models Related to doctr.models topic: text detection Related to the task of text detection topic: text recognition Related to the task of text recognition type: misc Miscellaneous labels Sep 15, 2022
@felixdittrich92 felixdittrich92 added this to the 0.6.0 milestone Sep 15, 2022
@felixdittrich92 felixdittrich92 self-assigned this Sep 15, 2022
@felixdittrich92 felixdittrich92 linked an issue Sep 15, 2022 that may be closed by this pull request
Turn off automatically download backbone model #991
Closed
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #1061 (98770b6) into main (a95baaa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1061   +/-   ##
=======================================
  Coverage   95.16%   95.16%           
=======================================
  Files         141      141           
  Lines        5827     5829    +2     
=======================================
+ Hits         5545     5547    +2     
  Misses        282      282
Flag Coverage Δ
unittests 95.16% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/detection/linknet/pytorch.py 99.03% <ø> (ø)
doctr/models/detection/zoo.py 96.96% <100.00%> (+0.09%) ⬆️
doctr/models/recognition/zoo.py 100.00% <100.00%> (ø)
doctr/models/zoo.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

frgfm
frgfm approved these changes Sep 16, 2022
View reviewed changes
Copy link
Collaborator

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Felix! A slight comment but that's quite alright

doctr/models/detection/zoo.py Show resolved Hide resolved
@felixdittrich92
Copy link
Contributor Author

will be merged after #1063 to avoid failing CI

@felixdittrich92 felixdittrich92 merged commit 0aacb3c into mindee:main Sep 19, 2022
@felixdittrich92 felixdittrich92 deleted the pretrained-backbone branch September 19, 2022 06:52
@felixdittrich92 felixdittrich92 mentioned this pull request Sep 26, 2022
Closed
85 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frgfm frgfm frgfm approved these changes

@charlesmindee charlesmindee Awaiting requested review from charlesmindee

@aminemindee aminemindee Awaiting requested review from aminemindee

@odulcy-mindee odulcy-mindee Awaiting requested review from odulcy-mindee

Assignees

@felixdittrich92 felixdittrich92

Labels
module: models Related to doctr.models topic: text detection Related to the task of text detection topic: text recognition Related to the task of text recognition type: misc Miscellaneous
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

Turn off automatically download backbone model
2 participants
@felixdittrich92 @frgfm