Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] detection script #1060

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

felixdittrich92
Copy link
Contributor

This PR:

  • refactored detection script
  • add ability to save also as xml
  • add minor test

Any feedback is welcome 🤗

@felixdittrich92 felixdittrich92 added type: enhancement Improvement topic: ci Related to CI ext: scripts Related to scripts folder labels Sep 15, 2022
@felixdittrich92 felixdittrich92 added this to the 0.6.0 milestone Sep 15, 2022
@felixdittrich92 felixdittrich92 self-assigned this Sep 15, 2022
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #1060 (0207ac1) into main (a95baaa) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1060      +/-   ##
==========================================
- Coverage   95.16%   95.12%   -0.04%     
==========================================
  Files         141      141              
  Lines        5827     5827              
==========================================
- Hits         5545     5543       -2     
- Misses        282      284       +2     
Flag Coverage Δ
unittests 95.12% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/transforms/functional/base.py 94.20% <0.00%> (-2.90%) ⬇️
doctr/transforms/modules/base.py 94.59% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@felixdittrich92 felixdittrich92 merged commit 42195de into mindee:main Sep 15, 2022
@felixdittrich92 felixdittrich92 deleted the refactor-det-script branch September 15, 2022 20:12
@felixdittrich92 felixdittrich92 mentioned this pull request Sep 26, 2022
85 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: scripts Related to scripts folder topic: ci Related to CI type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants