-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed return type of multithread_exec to iterator #1019
Changed return type of multithread_exec to iterator #1019
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1019 +/- ##
==========================================
+ Coverage 94.87% 94.93% +0.06%
==========================================
Files 135 135
Lines 5559 5590 +31
==========================================
+ Hits 5274 5307 +33
+ Misses 285 283 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mtvch 👋,
thanks for the PR.
LGTM 👍
Only isort and mypy left to fix:
Inside the project you can run make quality
to fix import sorting (isort) and get a output which changes you have to apply to make mypy happy :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I only have one comment about the potential latency change, let me know what you think :)
Actually, |
Hi @mtvch 👋 , any updates ? :) |
Hi, @felixdittrich92! |
Thanks for the information. yes no stress 🤗 |
@mtvch only mypy fix left :)
|
Sorry... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot LGTM 👍
multithread_exec
function returned result of different types depending on number of threads: if it's lesser than 2 -Iterator
, otherwise -list
.In every place this function is used, result is expected to be of type
list
and it fails if result is anIterator
.With this change function would always return
Iterator
to let user decide which type to convert it to.