Skip to content
This repository has been archived by the owner on Nov 28, 2019. It is now read-only.

Update options at runtime #49

Merged
merged 1 commit into from
May 15, 2015
Merged

Update options at runtime #49

merged 1 commit into from
May 15, 2015

Conversation

HaNdTriX
Copy link
Contributor

Right now options will not get updated.
Example Code:

// - Everything works as espected
$('#myBar')
  .attr('data-transitiongoal', 10)
  .progress({
    done: function foo() {
      console.log('foo');
    }
  });

// - Later in time
$('#myBar')
  .attr('data-transitiongoal', 10)
  .progress({
    done: function bar() {
      // This function will never get called
      // Instead foo is used
      console.log('bar');
    }
  });

This pull-request will solve this issue.

Right now options will not get updated.
Example Code:


    // - Everything works as espected
    $('#myBar')
      .attr('data-transitiongoal', 10)
      .progress({
        done: function foo() {
          console.log('foo');
        }
      });

    // - Later in time
    $('#myBar')
      .attr('data-transitiongoal', 10)
      .progress({
        done: function bar() {
          // This function will never get called
          console.log('bar');
        }
      });
@HaNdTriX HaNdTriX changed the title Make it possible to update options at runtime Update options at runtime May 13, 2015
@minddust
Copy link
Owner

@HaNdTriX nice! looks good to me. have to finish some work. will check this out tomorrow. note sure if this should be 0.8.6 or better 0.9.0 cause it might break some behavior on some peoples implementations.

@HaNdTriX
Copy link
Contributor Author

0.9.0 might be the right way to go. 👍

@minddust minddust merged commit 71d1670 into minddust:master May 15, 2015
@HaNdTriX
Copy link
Contributor Author

thx!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants