Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception On First Run With Multiple Displays #170

Closed
zachfedor opened this issue May 19, 2016 · 3 comments
Closed

Exception On First Run With Multiple Displays #170

zachfedor opened this issue May 19, 2016 · 3 comments

Comments

@zachfedor
Copy link

Just downloaded Min-v1.2.2-darwin-x64.zip from the releases page, unzipped, moved to Applications, and opened the app when I see this:

Uncaught Exception:
TypeError: Cannot read property 'getPrimaryDisplay' of null
    at createWindow (/Applications/Min.app/Contents/Resources/app/main.build.js:21:27)
    at EventEmitter.functionName (/Applications/Min.app/Contents/Resources/app/main.build.js:138:3)
    at emitTwo (events.js:92:20)
    at EventEmitter.emit (events.js:172:7)

I'm running OS X version 10.11.4 (15E65) on a MBP with an external monitor.

@PalmerAL PalmerAL added the bug label May 20, 2016
@PalmerAL
Copy link
Collaborator

It appears that OS X is triggering the activate event before the app is ready for some reason, which means that electron.screen hasn't loaded yet.

According to the Electron docs, this event "usually happens when the user clicks on the application’s dock icon", but I guess it can happen at other times as well.

PalmerAL added a commit that referenced this issue May 22, 2016
@PalmerAL
Copy link
Collaborator

I think this is fixed in 267e90a. Can you try building Min from the master branch and make sure this is fixed?

@zachfedor
Copy link
Author

This is fixed. Built using the instructions for devs in the project readme and ran without issue.

Thanks @PalmerAL!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants