Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode common argument results to prevent dup string allocations #135

Merged
merged 3 commits into from
Aug 12, 2018
Merged

Hardcode common argument results to prevent dup string allocations #135

merged 3 commits into from
Aug 12, 2018

Conversation

dillonwelch
Copy link
Contributor

No description provided.

@jeremyevans
Copy link
Contributor

This looks fine to me, but you should probably remove the changes to the gemspec. That file should actually be deleted since I think Hoe is now used in the Rakefile to create the gemspec.

@dillonwelch
Copy link
Contributor Author

Updated!

@halostatue
Copy link
Member

halostatue commented Aug 10, 2018

The gemspec is committed so that git-bundled uses of mime-types works, and the Gemfile specifies gemspec. It’s been a while, but if you install the necessary dependencies, it should be possible to type rake gemspec and it should automatically generate/update the .gemspec file.

@halostatue
Copy link
Member

Normally, I do this as part of release hygiene.

@dillonwelch
Copy link
Contributor Author

I can clean up all of the .freeze in the gemspec file too if you'd like

@halostatue
Copy link
Member

The gemspec is generated. If the .freeze methods are there, they get left there.

@halostatue halostatue self-assigned this Aug 10, 2018
@halostatue halostatue merged commit ca89015 into mime-types:master Aug 12, 2018
@dillonwelch dillonwelch deleted the common-values branch August 12, 2018 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants