Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Client to v2 API #3524

Merged
merged 3 commits into from
Dec 16, 2020
Merged

Update Client to v2 API #3524

merged 3 commits into from
Dec 16, 2020

Conversation

quentinlesceller
Copy link
Member

@quentinlesceller quentinlesceller commented Dec 14, 2020 •
edited
Loading

As titled. Fixes #3522.
JSON-RPC code is taken from mimblewimble/grin-wallet#329 (json-rpc.rs). Might be good to use the same code for both in the future.

@antiochp
Copy link
Member

Looks like there are build issues related to the json! macro.

@antiochp antiochp added this to the 5.0.0 milestone Dec 15, 2020
jaspervdm
jaspervdm approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@jaspervdm jaspervdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested locally and behaves as expected.

antiochp
antiochp reviewed Dec 15, 2020
View reviewed changes
Copy link
Member

@antiochp antiochp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine.
I'm testing this locally just to sanity check the various client api calls.

antiochp
antiochp approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@antiochp antiochp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@antiochp
Copy link
Member

Merging this. My understanding is this is the last PR outstanding for 5.0.x.

@antiochp antiochp merged commit 0114c95 into mimblewimble:current/5.0.x Dec 16, 2020
@quentinlesceller quentinlesceller mentioned this pull request Dec 18, 2020
Closed
@antiochp antiochp mentioned this pull request Dec 20, 2020
Closed
@quentinlesceller quentinlesceller deleted the c branch March 3, 2021 19:01
@quentinlesceller quentinlesceller mentioned this pull request Mar 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antiochp antiochp antiochp approved these changes

@jaspervdm jaspervdm jaspervdm approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@quentinlesceller @antiochp @jaspervdm