use extend_from_slice when appending multiple hashes to hash file #3497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaspervdm
approved these changes
Nov 24, 2020
Closed
bayk
added a commit
to mwcproject/mwc-node
that referenced
this pull request
Jun 8, 2024
to hash file (mimblewimble#3497) * use extend_from_slice when appending multiple hashes to hash file * bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the
Backendtrait, passing a slice of hashes toappend().Pass
&[Hash]intoappend()rather thanVec<Hash>.This lets us call
extend_from_slice()inVecBackendwithout cloning the vec of hashes.In PMMR backend we can use the slice directly and append multiple hashes.