Skip to content

Commit

Permalink
Extend grpcio version requirements range (#1033)
Browse files Browse the repository at this point in the history
To run pymilvus, we only need `grpcio`
To generate python files from protos, we need `grpcio-tools`

This PR:
1. Removes `grpcio-tools` from install requirements
2. Extends `grpcio` versions
3. Provides the compatible version ranges of `grpcio-tools` and `grpcio`

See also: #1030, #943, #946

Signed-off-by: XuanYang-cn <xuan.yang@zilliz.com>
  • Loading branch information
XuanYang-cn authored Jun 16, 2022
1 parent c4fd1c4 commit 15d41ab
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ $ git sumodule update --init

Q2. How to generate python files from milvus-proto?

**Before generating python files, please install requirements in `requirements.txt`**

A2.
```shell
$ make gen_proto
Expand Down
8 changes: 4 additions & 4 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
build==0.4.0
certifi==2021.5.30
chardet==4.0.0
grpcio==1.37.1
grpcio-testing==1.37.1
grpcio-tools==1.37.1
grpcio>=1.37.1
grpcio-testing>=1.37.1
grpcio-tools>=1.37.1,<=1.43.0
idna==2.10
mmh3>=2.0,<=3.0.0
packaging==20.9
Expand All @@ -28,7 +28,7 @@ sphinxcontrib-qthelp==1.0.2
sphinxcontrib-serializinghtml==1.1.3
sphinxcontrib-napoleon
sphinxcontrib-prettyspecialmethods
pytest==5.3.4
pytest>=5.3.4
pytest-cov==2.8.1
pytest-timeout==1.3.4
pylint==2.4.4
Expand Down
3 changes: 1 addition & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@
packages=setuptools.find_packages(),
include_package_data=True,
install_requires=[
"grpcio==1.37.1",
"grpcio-tools==1.37.1",
"grpcio>=1.37.1",
"ujson>=2.0.0,<=5.1.0",
"mmh3>=2.0,<=3.0.0",
"pandas==1.1.5; python_version<'3.7'",
Expand Down

0 comments on commit 15d41ab

Please sign in to comment.