Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify default value for sync max parallel to mitigate oom on dn(#26763) #26231

Merged

Conversation

MrPresent-Han
Copy link
Contributor

related: #25763

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 9, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Aug 9, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2023

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #26231 (a4397b5) into master (fb5d809) will increase coverage by 0.34%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26231      +/-   ##
==========================================
+ Coverage   82.22%   82.57%   +0.34%     
==========================================
  Files         817      811       -6     
  Lines      111187   108762    -2425     
==========================================
- Hits        91427    89810    -1617     
+ Misses      16652    15822     -830     
- Partials     3108     3130      +22     
Files Changed Coverage Δ
pkg/util/paramtable/component_param.go 98.13% <100.00%> (ø)

... and 176 files with indirect coverage changes

@MrPresent-Han
Copy link
Contributor Author

/run-cpu-e2e

1 similar comment
@MrPresent-Han
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2023

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2023

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@MrPresent-Han
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2023

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@MrPresent-Han
Copy link
Contributor Author

/run-cpu-e2e

@MrPresent-Han MrPresent-Han force-pushed the modify-default-max-sync-parallel branch from 6aa84f3 to a4397b5 Compare August 9, 2023 09:03
@mergify mergify bot added the ci-passed label Aug 9, 2023
@jiaoew1991
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiaoew1991, MrPresent-Han

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3421956 into milvus-io:master Aug 10, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants