Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for sparse vector #720

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

ThreadDao
Copy link
Contributor

No description provided.

@sre-ci-robot sre-ci-robot requested review from congqixia and sunby April 12, 2024 11:01
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Apr 12, 2024
@ThreadDao ThreadDao force-pushed the sparse-vector branch 2 times, most recently from a79c1d6 to 613b6ac Compare April 16, 2024 14:00
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Apr 16, 2024
@ThreadDao ThreadDao force-pushed the sparse-vector branch 2 times, most recently from 63e9b57 to 319b4f4 Compare April 16, 2024 15:53
@mergify mergify bot added the ci-passed auto merge needed label label Apr 16, 2024
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 72.01%. Comparing base (e697167) to head (040c212).

❗ Current head 040c212 differs from pull request most recent head 7745e56. Consider uploading reports for the commit 7745e56 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #720      +/-   ##
==========================================
- Coverage   72.07%   72.01%   -0.06%     
==========================================
  Files          51       51              
  Lines        4737     4742       +5     
==========================================
+ Hits         3414     3415       +1     
- Misses       1202     1206       +4     
  Partials      121      121              
Files Coverage Δ
client/collection.go 88.82% <100.00%> (+0.03%) ⬆️
entity/columns_sparse.go 86.66% <100.00%> (ø)
entity/rows.go 75.47% <0.00%> (-0.98%) ⬇️

Signed-off-by: ThreadDao <yufen.zong@zilliz.com>
@congqixia
Copy link
Contributor

/kind enhancement

@sre-ci-robot sre-ci-robot added the kind/enhancement New feature or request label Apr 18, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, ThreadDao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added lgtm look good to me approved review approved labels Apr 18, 2024
@sre-ci-robot sre-ci-robot merged commit 1c53c8f into milvus-io:master Apr 18, 2024
7 checks passed
@ThreadDao ThreadDao deleted the sparse-vector branch April 18, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/enhancement New feature or request lgtm look good to me size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants