Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow specify scalar index type #691

Merged

Conversation

congqixia
Copy link
Contributor

Related to #671

Related to milvus-io#671

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot requested a review from sunby April 2, 2024 03:44
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested a review from yah01 April 2, 2024 03:44
@sre-ci-robot sre-ci-robot added the approved review approved label Apr 2, 2024
@congqixia
Copy link
Contributor Author

/kind bug

@sre-ci-robot sre-ci-robot added kind/bug Something isn't working size/M Denotes a PR that changes 30-99 lines. labels Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.91%. Comparing base (3eabbb5) to head (c1579b9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #691      +/-   ##
==========================================
+ Coverage   71.81%   71.91%   +0.09%     
==========================================
  Files          51       51              
  Lines        4748     4750       +2     
==========================================
+ Hits         3410     3416       +6     
+ Misses       1214     1210       -4     
  Partials      124      124              
Files Coverage Δ
entity/index.go 100.00% <ø> (ø)
entity/index_scalar.go 85.71% <100.00%> (+85.71%) ⬆️

@mergify mergify bot added the ci-passed auto merge needed label label Apr 2, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Apr 2, 2024
@sre-ci-robot sre-ci-robot merged commit f2735a1 into milvus-io:master Apr 2, 2024
7 checks passed
@congqixia congqixia deleted the fix/allow_specifiy_scalar_idxtype branch April 11, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/bug Something isn't working lgtm look good to me size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants