Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SCANN index type #552

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Conversation

congqixia
Copy link
Contributor

See also milvus-io/milvus#26099
/kind improvement

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Aug 11, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested review from sunby and yah01 August 11, 2023 08:24
@sre-ci-robot sre-ci-robot added approved review approved size/L Denotes a PR that changes 100-499 lines. labels Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #552 (a1dbddf) into master (2607d41) will increase coverage by 0.10%.
Report is 1 commits behind head on master.
The diff coverage is 93.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
+ Coverage   82.91%   83.01%   +0.10%     
==========================================
  Files          39       39              
  Lines        3599     3632      +33     
==========================================
+ Hits         2984     3015      +31     
- Misses        503      504       +1     
- Partials      112      113       +1     
Files Changed Coverage Δ
entity/index.go 100.00% <ø> (ø)
entity/indexes_search_param_gen.go 98.34% <85.71%> (-1.66%) ⬇️
entity/indexes_gen.go 100.00% <100.00%> (ø)

@mergify mergify bot added the ci-passed auto merge needed label label Aug 11, 2023
@yah01
Copy link
Member

yah01 commented Aug 11, 2023

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Aug 11, 2023
@sre-ci-robot sre-ci-robot merged commit 43d8b12 into milvus-io:master Aug 11, 2023
@congqixia congqixia deleted the support_scann_idx branch August 28, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants