Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto index search params #325

Merged

Conversation

xiaocai2333
Copy link
Contributor

Signed-off-by: cai.zhang cai.zhang@zilliz.com

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Oct 18, 2022
@mergify
Copy link

mergify bot commented Oct 18, 2022

@xiaocai2333 Please associate the related issue to the body of your Pull Request. (eg. “issue: #187”)

@mergify mergify bot added the ci-passed auto merge needed label label Oct 18, 2022
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #325 (9f6954a) into master (d850957) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
+ Coverage   88.02%   88.11%   +0.09%     
==========================================
  Files          26       26              
  Lines        2805     2827      +22     
==========================================
+ Hits         2469     2491      +22     
  Misses        247      247              
  Partials       89       89              
Impacted Files Coverage Δ
entity/index.go 100.00% <ø> (ø)
entity/indexes_gen.go 99.00% <100.00%> (+0.03%) ⬆️
entity/indexes_search_param_gen.go 100.00% <100.00%> (ø)

@congqixia
Copy link
Contributor

@xiaocai2333 entity/indexes_search_param_gen.go is a generated file. Maybe we shall move GeneralParam to index.go or follow the generation rules.

@xiaocai2333 xiaocai2333 force-pushed the add_generic_search_params branch from 69d40cb to 1de13d6 Compare October 18, 2022 11:34
@mergify mergify bot removed the ci-passed auto merge needed label label Oct 18, 2022
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
@xiaocai2333 xiaocai2333 force-pushed the add_generic_search_params branch from 1de13d6 to 9f6954a Compare October 18, 2022 11:57
@mergify mergify bot added the ci-passed auto merge needed label label Oct 18, 2022
@xiaocai2333
Copy link
Contributor Author

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Oct 18, 2022
@xiaocai2333 xiaocai2333 changed the title Add genernic search params Add auto index search params Oct 18, 2022
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/gltm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Oct 18, 2022
@congqixia
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Oct 18, 2022
@sre-ci-robot sre-ci-robot merged commit 306b5e6 into milvus-io:master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants