Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename bulkload to bulkinsert and support options #322

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

wayblink
Copy link
Contributor

@wayblink wayblink commented Oct 13, 2022

/kind improvement

Signed-off-by: wayblink anyang.wang@zilliz.com

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Oct 13, 2022
@mergify
Copy link

mergify bot commented Oct 13, 2022

@wayblink Please associate the related issue to the body of your Pull Request. (eg. “issue: #187”)

@wayblink
Copy link
Contributor Author

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Oct 13, 2022
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #322 (43ecb0d) into master (07d246e) will decrease coverage by 0.28%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
- Coverage   88.30%   88.01%   -0.29%     
==========================================
  Files          26       26              
  Lines        2796     2804       +8     
==========================================
- Hits         2469     2468       -1     
- Misses        238      247       +9     
  Partials       89       89              
Impacted Files Coverage Δ
client/client.go 71.42% <ø> (ø)
client/client_grpc_data.go 71.57% <0.00%> (-0.21%) ⬇️
client/client_grpc_options.go 80.00% <0.00%> (-20.00%) ⬇️

Signed-off-by: wayblink <anyang.wang@zilliz.com>
@mergify mergify bot added the ci-passed auto merge needed label label Oct 13, 2022
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Oct 14, 2022
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, wayblink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Oct 14, 2022
@sre-ci-robot sre-ci-robot merged commit c232837 into milvus-io:master Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants