Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timestamp bug #288

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Conversation

letian-jiang
Copy link
Contributor

Thanks for @xiaocai2333

Signed-off-by: Letian Jiang letian.jiang@zilliz.com

Signed-off-by: Letian Jiang <letian.jiang@zilliz.com>
@mergify
Copy link

mergify bot commented Jul 15, 2022

@letian-jiang Please associate the related issue to the body of your Pull Request. (eg. “issue: #187”)

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 15, 2022
@letian-jiang
Copy link
Contributor Author

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Jul 15, 2022
@mergify mergify bot added ci-passed auto merge needed label and removed do-not-merge/missing-related-issue labels Jul 15, 2022
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #288 (cee1bc0) into master (e42d7a9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #288   +/-   ##
=======================================
  Coverage   90.18%   90.18%           
=======================================
  Files          23       23           
  Lines        2609     2609           
=======================================
  Hits         2353     2353           
  Misses        173      173           
  Partials       83       83           
Impacted Files Coverage Δ
client/client_grpc_data.go 77.34% <100.00%> (ø)

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Jul 15, 2022
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, letian-jiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Jul 15, 2022
@sre-ci-robot sre-ci-robot merged commit b35d760 into milvus-io:master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants