Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connect test cases #214

Closed
wants to merge 6 commits into from
Closed

Conversation

ThreadDao
Copy link
Contributor

@ThreadDao ThreadDao commented Oct 11, 2021

  • add main_test file
  • add connect_test file

issue: #215

Signed-off-by: ThreadDao yufen.zong@zilliz.com

Signed-off-by: ThreadDao <yufen.zong@zilliz.com>
Signed-off-by: ThreadDao <yufen.zong@zilliz.com>
@mergify
Copy link

mergify bot commented Oct 11, 2021

@ThreadDao Please associate the related issue to the body of your Pull Request. (eg. “issue: #187”)

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Oct 11, 2021
tests/main_test.go Outdated Show resolved Hide resolved
tests/main_test.go Outdated Show resolved Hide resolved
Signed-off-by: ThreadDao <yufen.zong@zilliz.com>
Signed-off-by: ThreadDao <yufen.zong@zilliz.com>
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, ThreadDao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added lgtm look good to me approved review approved labels Oct 12, 2021
@congqixia
Copy link
Contributor

@ThreadDao please sign and squash the pr commits. Sdk project has same standard of milvus.

Signed-off-by: ThreadDao <yufen.zong@zilliz.com>
Signed-off-by: ThreadDao <yufen.zong@zilliz.com>
@sre-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@sre-ci-robot sre-ci-robot removed the lgtm look good to me label Oct 12, 2021
@ThreadDao ThreadDao closed this Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants