Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip ci] Update Go SDK contributing guide #196

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

LocoRichard
Copy link
Contributor

@LocoRichard LocoRichard commented Sep 10, 2021

Fix #197
Signed-off-by: LocoRichard lichen.wang@zilliz.com

Signed-off-by: LocoRichard <lichen.wang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Sep 10, 2021
@mergify mergify bot added the ci-passed auto merge needed label label Sep 10, 2021
@mergify
Copy link

mergify bot commented Sep 10, 2021

@LocoRichard Please associate the related issue to the body of your Pull Request. (eg. “issue: #187”)

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Sep 10, 2021
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, LocoRichard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Sep 10, 2021
@sre-ci-robot sre-ci-robot merged commit e1c1444 into milvus-io:master Sep 10, 2021
@LocoRichard LocoRichard deleted the add-contributing branch September 10, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label lgtm look good to me size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc] Update contributing guide
3 participants