VoyageAI: Adding new models, quantization and multiple output dimensions #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
|
|
||
| if embedding_type == "int8" or embedding_type == "uint8": | ||
| raise ValueError("Currently int8 or uint8 is not supported with PyMilvus model library.") |
There was a problem hiding this comment.
curious, is this not supported because of python, or the implementation of PyMilvus model library particularly?
There was a problem hiding this comment.
@codingjaguar I copied this check from Cohere's implementation (
milvus-model/milvus_model/dense/cohere.py
Line 29 in ddc1268
There was a problem hiding this comment.
Got it. It's Milvus doesn't support int8 or uint8 type of vectors (it support binary, float, float16 etc). Please keep it. Thanks!
codingjaguar
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VoyageAI: Adding new models, quantization and multiple output dimensions (for the models supporting it)