[Stack Monitoring] Add stale status reporting for Kibana (elastic#126386

)
miltonhultgren · May 31, 2022 · 011a04f · 011a04f
1 parent ac5d003
commit 011a04f
Show file tree

Hide file tree

Showing 16 changed files with 495 additions and 115 deletions.
diff --git a/docs/settings/monitoring-settings.asciidoc b/docs/settings/monitoring-settings.asciidoc
@@ -137,6 +137,10 @@ represent. Defaults to 10. If you modify the
 `monitoring.ui.collection.interval` in `elasticsearch.yml`, use the same
 value in this setting.
 
+`monitoring.ui.kibana.reporting.stale_status_threshold_seconds`::
+Specifies how many seconds can pass before the Kibana status reports are considered stale.
+Defaults to `120`.
+
 [float]
 [[monitoring-ui-cgroup-settings]]
 ===== Monitoring UI container settings

diff --git a/x-pack/plugins/monitoring/public/application/contexts/external_config_context.tsx b/x-pack/plugins/monitoring/public/application/contexts/external_config_context.tsx
@@ -12,6 +12,7 @@ export interface ExternalConfig {
   showCgroupMetricsElasticsearch: boolean;
   showCgroupMetricsLogstash: boolean;
   renderReactApp: boolean;
+  staleStatusThresholdSeconds: number;
 }
 
 export const ExternalConfigContext = createContext({} as ExternalConfig);
diff --git a/x-pack/plugins/monitoring/public/components/cluster/overview/kibana_panel.js b/x-pack/plugins/monitoring/public/components/cluster/overview/kibana_panel.js
@@ -5,52 +5,54 @@
  * 2.0.
  */
 
-import React from 'react';
-import { formatNumber } from '../../../lib/format_number';
-import {
-  ClusterItemContainer,
-  HealthStatusIndicator,
-  BytesPercentageUsage,
-  DisabledIfNoDataAndInSetupModeLink,
-} from './helpers';
-import { get } from 'lodash';
 import {
+  EuiDescriptionList,
+  EuiDescriptionListDescription,
+  EuiDescriptionListTitle,
   EuiFlexGrid,
   EuiFlexGroup,
   EuiFlexItem,
+  EuiHorizontalRule,
   EuiLink,
-  EuiTitle,
   EuiPanel,
-  EuiDescriptionList,
-  EuiDescriptionListTitle,
-  EuiDescriptionListDescription,
-  EuiHorizontalRule,
+  EuiTitle,
+  EuiIcon,
+  EuiToolTip,
 } from '@elastic/eui';
-import { FormattedMessage } from '@kbn/i18n-react';
 import { i18n } from '@kbn/i18n';
-import { SetupModeTooltip } from '../../setup_mode/tooltip';
+import { FormattedMessage } from '@kbn/i18n-react';
+import { get } from 'lodash';
+import React from 'react';
 import { KIBANA_SYSTEM_ID, RULE_KIBANA_VERSION_MISMATCH } from '../../../../common/constants';
-import { getSafeForExternalLink } from '../../../lib/get_safe_for_external_link';
+import { SetupModeFeature } from '../../../../common/enums';
 import { AlertsBadge } from '../../../alerts/badge';
 import { shouldShowAlertBadge } from '../../../alerts/lib/should_show_alert_badge';
+import { formatNumber } from '../../../lib/format_number';
+import { getSafeForExternalLink } from '../../../lib/get_safe_for_external_link';
 import { isSetupModeFeatureEnabled } from '../../../lib/setup_mode';
-import { SetupModeFeature } from '../../../../common/enums';
+import { ExternalConfigContext } from '../../../application/contexts/external_config_context';
 import { SetupModeContext } from '../../setup_mode/setup_mode_context';
+import { SetupModeTooltip } from '../../setup_mode/tooltip';
+import {
+  BytesPercentageUsage,
+  ClusterItemContainer,
+  DisabledIfNoDataAndInSetupModeLink,
+  HealthStatusIndicator,
+} from './helpers';
 
 const INSTANCES_PANEL_ALERTS = [RULE_KIBANA_VERSION_MISMATCH];
 
 export function KibanaPanel(props) {
   const setupMode = props.setupMode;
   const alerts = props.alerts;
   const setupModeContext = React.useContext(SetupModeContext);
+  const { staleStatusThresholdSeconds } = React.useContext(ExternalConfigContext);
   const showDetectedKibanas =
     setupMode.enabled && get(setupMode.data, 'kibana.detected.doesExist', false);
   if (!props.count && !showDetectedKibanas) {
     return null;
   }
 
-  const statusIndicator = <HealthStatusIndicator status={props.status} product={'kb'} />;
-
   const goToKibana = () => getSafeForExternalLink('#/kibana');
   const goToInstances = () => getSafeForExternalLink('#/kibana/instances');
 
@@ -78,7 +80,12 @@ export function KibanaPanel(props) {
   return (
     <ClusterItemContainer
       {...props}
-      statusIndicator={statusIndicator}
+      statusIndicator={statusIndicator(
+        props.status,
+        props.some_status_is_stale,
+        goToInstances(),
+        staleStatusThresholdSeconds
+      )}
       url="kibana"
       title={i18n.translate('xpack.monitoring.cluster.overview.kibanaPanel.kibanaTitle', {
         defaultMessage: 'Kibana',
@@ -203,3 +210,44 @@ export function KibanaPanel(props) {
     </ClusterItemContainer>
   );
 }
+
+function statusIndicator(status, someStatusIsStale, instancesHref, staleStatusThresholdSeconds) {
+  if (!someStatusIsStale) {
+    return <HealthStatusIndicator status={status} product={'kb'} />;
+  }
+
+  const staleMessage = i18n.translate(
+    'xpack.monitoring.cluster.overview.kibanaPanel.staleStatusTooltip',
+    {
+      defaultMessage:
+        "It's been more than {staleStatusThresholdSeconds} seconds since we heard from some instances.",
+      values: {
+        staleStatusThresholdSeconds,
+      },
+    }
+  );
+
+  return (
+    <>
+      <div>
+        <EuiToolTip position="top" content={staleMessage}>
+          <>
+            <EuiIcon size="l" type="alert" color="warning" />
+            &nbsp;
+            {i18n.translate('xpack.monitoring.cluster.overview.kibanaPanel.staleStatusLabel', {
+              defaultMessage: 'Stale',
+            })}
+          </>
+        </EuiToolTip>
+      </div>
+      <EuiLink href={instancesHref}>
+        {i18n.translate(
+          'xpack.monitoring.cluster.overview.kibanaPanel.staleStatusLinkToInstancesLabel',
+          {
+            defaultMessage: 'View all instances',
+          }
+        )}
+      </EuiLink>
+    </>
+  );
+}
diff --git a/x-pack/plugins/monitoring/public/components/kibana/cluster_status/index.js b/x-pack/plugins/monitoring/public/components/kibana/cluster_status/index.js
@@ -5,11 +5,15 @@
  * 2.0.
  */
 
+import { EuiLink, EuiToolTip, EuiIcon, EuiStat } from '@elastic/eui';
+import { i18n } from '@kbn/i18n';
 import React from 'react';
-import { SummaryStatus } from '../../summary_status';
-import { KibanaStatusIcon } from '../status_icon';
+import { useLocation } from 'react-router-dom';
 import { formatMetric } from '../../../lib/format_number';
-import { i18n } from '@kbn/i18n';
+import { getSafeForExternalLink } from '../../../lib/get_safe_for_external_link';
+import { ExternalConfigContext } from '../../../application/contexts/external_config_context';
+import { SummaryStatus, DefaultStatusIndicator } from '../../summary_status';
+import { KibanaStatusIcon } from '../status_icon';
 
 export function ClusterStatus({ stats, alerts }) {
   const {
@@ -20,8 +24,12 @@ export function ClusterStatus({ stats, alerts }) {
     requests_total: requests,
     response_time_max: maxResponseTime,
     status,
+    some_status_is_stale: someStatusIsStale,
   } = stats;
 
+  const { staleStatusThresholdSeconds } = React.useContext(ExternalConfigContext);
+  const location = useLocation();
+
   const metrics = [
     {
       label: i18n.translate('xpack.monitoring.kibana.clusterStatus.instancesLabel', {
@@ -60,15 +68,103 @@ export function ClusterStatus({ stats, alerts }) {
     },
   ];
 
-  const IconComponent = ({ status }) => <KibanaStatusIcon status={status} />;
+  const StatusIndicator = () => {
+    if (!someStatusIsStale) {
+      return (
+        <DefaultStatusIndicator status={status} isOnline={true} IconComponent={KibanaStatusIcon} />
+      );
+    }
+
+    const staleMessage = i18n.translate(
+      'xpack.monitoring.kibana.clusterStatus.staleStatusTooltip',
+      {
+        defaultMessage:
+          "It's been more than {staleStatusThresholdSeconds} seconds since we heard from some instances.",
+        values: {
+          staleStatusThresholdSeconds,
+        },
+      }
+    );
+
+    if (location.pathname === '/kibana') {
+      return <OverviewPageStatusIndicator staleMessage={staleMessage} />;
+    }
+
+    return <InstancesPageStatusIndicator staleMessage={staleMessage} />;
+  };
 
   return (
     <SummaryStatus
-      metrics={metrics}
-      status={status}
+      StatusIndicator={StatusIndicator}
       alerts={alerts}
-      IconComponent={IconComponent}
+      metrics={metrics}
       data-test-subj="kibanaClusterStatus"
     />
   );
 }
+
+function OverviewPageStatusIndicator({ staleMessage }) {
+  const instancesHref = getSafeForExternalLink('#/kibana/instances');
+
+  const title = (
+    <>
+      <div>
+        <EuiToolTip position="top" content={staleMessage}>
+          <>
+            <EuiIcon size="l" type="alert" color="warning" />
+            &nbsp;
+            {i18n.translate('xpack.monitoring.kibana.clusterStatus.staleStatusInstancesLabel', {
+              defaultMessage: 'Stale',
+            })}
+          </>
+        </EuiToolTip>
+      </div>
+      <EuiLink href={instancesHref}>
+        {i18n.translate(
+          'xpack.monitoring.cluster.overview.kibanaPanel.staleStatusLinkToInstancesLabel',
+          {
+            defaultMessage: 'View all instances',
+          }
+        )}
+      </EuiLink>
+    </>
+  );
+
+  return (
+    <EuiStat
+      description={i18n.translate('xpack.monitoring.kibana.clusterStatus.statusLabel', {
+        defaultMessage: 'Status',
+      })}
+      title={title}
+      titleSize="xxxs"
+      textAlign="left"
+      className="monSummaryStatusNoWrap__stat"
+    />
+  );
+}
+
+function InstancesPageStatusIndicator({ staleMessage }) {
+  const title = (
+    <EuiToolTip position="top" content={staleMessage}>
+      <span>
+        <EuiIcon size="l" type="alert" color="warning" />
+        &nbsp;
+        {i18n.translate('xpack.monitoring.kibana.clusterStatus.staleStatusInstancesLabel', {
+          defaultMessage: 'Stale',
+        })}
+      </span>
+    </EuiToolTip>
+  );
+
+  return (
+    <EuiStat
+      description={i18n.translate('xpack.monitoring.kibana.clusterStatus.statusLabel', {
+        defaultMessage: 'Status',
+      })}
+      title={title}
+      titleSize="xxxs"
+      textAlign="left"
+      className="monSummaryStatusNoWrap__stat"
+    />
+  );
+}