Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Reconnection scenarios #130

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Conversation

aravind-raveendran
Copy link
Collaborator

  1. Publisher stopping and starting the publishing while the subscriber is still viewing
  2. Not showing an error when the publisher stops where the sourceId is empty or null

1. Publisher stopping and starting the publishing while the subscriber is still viewing
2. Not showing an error when the publisher stops where the sourceId is empty or null
@aravind-raveendran aravind-raveendran force-pushed the bugfix/reconnection-scenarios branch from 9933508 to cf7b4f1 Compare February 19, 2024 03:30
@aravind-raveendran aravind-raveendran force-pushed the bugfix/reconnection-scenarios branch from 141ca96 to 0506747 Compare February 19, 2024 04:10
Copy link
Collaborator

@ldanilina ldanilina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aravind-raveendran aravind-raveendran merged commit a91cf05 into main Feb 19, 2024
1 check passed
@aravind-raveendran aravind-raveendran deleted the bugfix/reconnection-scenarios branch February 19, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants