modifying to not require --testMatch for windows

millicast · Dec 3, 2024 · af79e7e · af79e7e
1 parent 8385430
commit af79e7e
Show file tree

Hide file tree

Showing 4 changed files with 54 additions and 102 deletions.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -168,9 +168,15 @@ If you only want to run E2E tests, in the command line run:
 npm run test-e2e
 ```
 
+NOTE: on Windows, the `--testMatch` param that is used to isolate tests down to a directory will not work. Instead run all tests:
+
+```sh
+npm run test
+```
+
 ### Building docs
 
-The SDK documentation is written with [JSDcos](https://jsdoc.app/). To build the HTML documentation, run:
+The SDK documentation is written with [JSDocs](https://jsdoc.app/). To build the HTML documentation, run:
 
 ```sh
 npx lerna run build-docs

diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/millicast-sdk/jest.config.ts b/packages/millicast-sdk/jest.config.ts
@@ -3,6 +3,7 @@ export default {
   displayName: 'millicast-sdk',
   preset: '../../jest.preset.js',
   testEnvironment: 'jsdom',
+  testMatch: ['**/__tests__/**/*.[jt]s?(x)', '**/?(*.)+(spec|steps).[jt]s?(x)'],
   clearMocks: true,
   transform: {
     '^.+\\.[tj]s$': ['ts-jest', { tsconfig: '<rootDir>/tsconfig.spec.json' }],

diff --git a/packages/millicast-sdk/package.json b/packages/millicast-sdk/package.json
@@ -23,7 +23,7 @@
     "test-unit": "npm run build && jest --testMatch '**/unit/*.steps.js'",
     "test-unit-coverage": "npm run build && jest --testMatch '**/unit/*.steps.js' --coverage",
     "test-e2e": "npm run build && jest --testMatch '**/e2e/*.steps.js'",
-    "test-all": "npm run build && jest --testMatch '**/*.steps.js'",
+    "test-all": "npm run build && jest",
     "test": "npm run test-all"
   },
   "babel": {
@@ -49,5 +49,7 @@
     "type": "git",
     "url": "git+https://github.com/millicast/millicast-sdk.git"
   },
-  "devDependencies": {}
+  "dependencies": {
+    "playwright": "^1.49.0"
+  }
 }