fix: Metadata types causing errors upon publish and subscribe (#477)

millicast · Nov 18, 2024 · 0cfb5af · 0cfb5af
1 parent e70294f
commit 0cfb5af
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/packages/millicast-sdk/src/View.ts b/packages/millicast-sdk/src/View.ts
@@ -29,6 +29,7 @@ import {
 } from './types/View.types.js'
 import { DRMProfile } from './types/Director.types'
 import { DecodedJWT, Media } from './types/BaseWebRTC.types'
+import { VideoCodec } from './types/Codecs.types'
 
 const logger = Logger.get('View')
 logger.setLevel(Logger.DEBUG)
@@ -486,7 +487,7 @@ export default class View extends BaseWebRTC {
         trackEvent.receiver.transform = new RTCRtpScriptTransform(this.worker, {
           name: 'receiverTransform',
           payloadTypeCodec: { ...this.payloadTypeCodec },
-          codec: this.options.metadata && 'h264',
+          codec: this.options.metadata && VideoCodec.H264,
           mid: trackEvent.transceiver?.mid,
         })
       } else if (supportsInsertableStreams) {
@@ -496,7 +497,7 @@ export default class View extends BaseWebRTC {
           {
             action: 'insertable-streams-receiver',
             payloadTypeCodec: { ...this.payloadTypeCodec },
-            codec: this.options.metadata && 'h264',
+            codec: this.options.metadata && VideoCodec.H264,
             mid: trackEvent.transceiver?.mid,
             readable,
             writable,

diff --git a/packages/millicast-sdk/src/utils/Codecs.ts b/packages/millicast-sdk/src/utils/Codecs.ts
@@ -653,7 +653,7 @@ function numberToByteArray(num: number) {
   if (!isNaN(num)) {
     const bigint = BigInt(num)
     for (let i = 0; i < Math.ceil(Math.floor(Math.log2(num) + 1) / 8); i++) {
-      array.unshift(((bigint >> BigInt(8 * i)) & BigInt(255)) as unknown as number)
+      array.unshift(Number((bigint >> BigInt(8 * i)) & BigInt(255)))
     }
   }
   return new Uint8Array(array)

diff --git a/packages/millicast-sdk/src/workers/TransformWorker.worker.ts b/packages/millicast-sdk/src/workers/TransformWorker.worker.ts
@@ -26,8 +26,8 @@ function createReceiverTransform(mid: string) {
       // eslint-disable-next-line no-undef
       if (encodedFrame instanceof RTCEncodedVideoFrame) {
         const payloadType = encodedFrame.getMetadata().payloadType
-        const frameCodec = payloadType ? payloadTypeCodec[payloadType] : codec
-        if (frameCodec === 'H264') {
+        const frameCodec = payloadType ? payloadTypeCodec[payloadType].toLowerCase() : codec
+        if (frameCodec === VideoCodec.H264) {
           const metadata = extractH26xMetadata(encodedFrame, frameCodec as VideoCodec)
           if (
             metadata.timecode ||