Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #1238 from joroKr21/default-access #1239

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

joroKr21
Copy link
Collaborator

@joroKr21 joroKr21 commented Feb 11, 2022

Access nested defaults through this to avoid stack overflow

Forward ports #1238
Fixes #1099

Access nested defaults through this to avoid stack overflow
@joroKr21 joroKr21 added the Bug label Feb 11, 2022
@joroKr21 joroKr21 self-assigned this Feb 11, 2022
@joroKr21 joroKr21 requested a review from milessabin February 11, 2022 07:39
Copy link
Owner

@milessabin milessabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joroKr21 joroKr21 merged commit 2aebbc1 into milessabin:main Feb 11, 2022
@joroKr21 joroKr21 deleted the defaults branch February 11, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default.AsRecord causes StackOverflow in a path-dependent type's companion object
2 participants