Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Improve mdx-loader usage. #134

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Conversation

boenrobot
Copy link
Contributor

@boenrobot boenrobot commented Feb 8, 2024

Explicitly require mdx loader as an optional peer dependency.

Added rimraf as a dev dependency to enable cross platform removal of the tsconfig.lib.tsbuildinfo file, and thus cross platform builds.

Fix configuration to satisfy the mdx loader's options (specifically, the static folders and site dir).

Adjusted the whitelisting to only include files that are enabled, rather than include both if either changelogs or readmes are enabled.

Removed an unnecessary await in extractSidebar call.


I'm not 100% sure about the siteDir config, but then again, it's required, so something should be put there. Just not sure if copying the global siteDir is correct, or if some context/config/package specific folder is the correct path.

packages/plugin/package.json Outdated Show resolved Hide resolved
@boenrobot boenrobot force-pushed the mdxLoaderUpdate branch 2 times, most recently from fad9565 to d1eccac Compare February 9, 2024 16:39
…ions (specifically, the static folders and site dir).

deps(mdx-loader): Explicitly require mdx loader as a peer dependency.
deps(rimraf): Added rimraf as a dev dependency to enable cross platform removal of the tsconfig.lib.tsbuildinfo file, and thus cross platform builds.
fix: Adjusted the whitelisting to only include files that are enabled, rather than include both if either changelogs or readmes are enabled.
perf: Removed an unnecessary await in extractSidebar call.
@milesj milesj changed the title MDX loader type fixes internal: Improve mdx-loader usage. Feb 11, 2024
@milesj milesj merged commit a9f1440 into milesj:master Feb 11, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants