Use unknown for inferrence.

milesj · Mar 19, 2019 · e15bb5b · e15bb5b
1 parent a9aa5bf
commit e15bb5b
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 9 deletions.
diff --git a/packages/core/src/Task.ts b/packages/core/src/Task.ts
@@ -29,7 +29,10 @@ export interface TaskMetadata {
   stopTime: number;
 }
 
-export default class Task<Ctx extends Context, Events extends TaskEvents> extends Emitter<Events> {
+export default class Task<
+  Ctx extends Context,
+  Events extends TaskEvents = TaskEvents
+> extends Emitter<Events> {
   action: TaskAction<Ctx>;
 
   // @ts-ignore Set after instantiation

diff --git a/packages/emitter/src/types.ts b/packages/emitter/src/types.ts
@@ -1,9 +1,10 @@
 // prettier-ignore
 export type Arguments<T> =
-  T extends (...args: infer A) => any ? A :
-  T extends any[] ? T :
+  T extends (...args: infer A) => unknown ? A :
+  T extends unknown[] ? T :
   never;
 
+// VALID
 // type A = Arguments<[number]>;
 // type B = Arguments<[number, string]>;
 // type C = Arguments<[number, boolean, string?]>;
@@ -12,14 +13,15 @@ export type Arguments<T> =
 // type F = Arguments<(a: string, b: number) => boolean | void>;
 // type G = Arguments<(a: string, b: number, c?: object) => string>;
 
-export type WaterfallArgument<T> = T extends (value: infer A) => any ? A : T;
+export type WaterfallArgument<T> = T extends (value: infer A) => unknown ? A : T;
 
 // prettier-ignore
 export type ListenerType<T> =
-  T extends (...args: any[]) => boolean | any ? T :
-  T extends any[] ? (...args: T) => boolean | void :
+  T extends (...args: any[]) => any ? T :
+  T extends unknown[] ? (...args: T) => boolean | void :
   never;
 
+// VALID
 // type H = ListenerType<(a: string, b: number, c?: object) => string>;
 // type I = ListenerType<(a: string) => Promise<boolean>>;
 // type J = ListenerType<(a: string, b: number) => boolean | void>;

diff --git a/yarn.lock b/yarn.lock
@@ -8798,9 +8798,9 @@ typedarray@^0.0.6:
   integrity sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=
 
 typescript@^3.3.3, typescript@~3.3.1:
-  version "3.3.3"
-  resolved "https://registry.npmjs.org/typescript/-/typescript-3.3.3.tgz#f1657fc7daa27e1a8930758ace9ae8da31403221"
-  integrity sha512-Y21Xqe54TBVp+VDSNbuDYdGw0BpoR/Q6wo/+35M8PAU0vipahnyduJWirxxdxjsAkS7hue53x2zp8gz7F05u0A==
+  version "3.3.3333"
+  resolved "https://registry.npmjs.org/typescript/-/typescript-3.3.3333.tgz#171b2c5af66c59e9431199117a3bcadc66fdcfd6"
+  integrity sha512-JjSKsAfuHBE/fB2oZ8NxtRTk5iGcg6hkYXMnZ3Wc+b2RSqejEqTaem11mHASMnFilHrax3sLK0GDzcJrekZYLw==
 
 uglify-js@^3.1.4:
   version "3.4.9"