Refactor implementation and optional mimalloc #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The stream* functions are pretty simple - a fair comparison would be by instantiating StreamDe/Compressor directly.
…On February 21, 2021 8:55:38 AM EST, Miles Granger ***@***.***> wrote:
Generalization, and other updates/optimizations
@martindurant Here I've noticed, given a previous comment of yours,
that snappy benchmarks were comparing cramjam framed vs
python-snappy's raw format. After updating, the raw formats are
basically the same; cramjam slightly slower in smaller files, then
edges passed python-snappy in the larger files.
I'm unsure of my current benchmark for the framed format, cramjam
is significantly faster and obviously due to having to push data into
file-like objects for `snappy.stream_de/compress`. Do you have any
suggestions, maybe I should just leave that benchmark version out?
You can view, comment on, or merge this pull request online at:
#36
-- Commit Summary --
* chkpt: start refactoring
-- File Changes --
M Cargo.toml (6)
M Makefile (7)
M benchmarks/test_bench.py (51)
M src/brotli.rs (119)
M src/deflate.rs (120)
M src/gzip.rs (124)
M src/lib.rs (108)
M src/snappy.rs (95)
M src/zstd.rs (120)
-- Patch Links --
https://github.com/milesgranger/pyrus-cramjam/pull/36.patch
https://github.com/milesgranger/pyrus-cramjam/pull/36.diff
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#36
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
milesgranger
force-pushed
the
refactor-resize-bytearray-n-writer-traits
branch
from
7ec5f1a to
9c0a7de
Compare
milesgranger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalization, and other updates/optimizations
@martindurant Here I've noticed, given a previous comment of yours, that snappy benchmarks were comparing cramjam framed vs python-snappy's raw format. After updating, the raw formats are basically the same; cramjam slightly slower in smaller files, then edges passed python-snappy in the larger files.
I'm unsure of my current benchmark for the framed format, cramjam is significantly faster and obviously due to having to push data into file-like objects for
snappy.stream_de/compress. Do you have any suggestions, maybe I should just leave that benchmark version out?Will close #25