Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible ci testing pr #3

Closed
wants to merge 4 commits into from
Closed

Ansible ci testing pr #3

wants to merge 4 commits into from

Conversation

mildas
Copy link
Owner

@mildas mildas commented May 21, 2024

Description:

  • Description here. Replace this text. Don't use the italics format!

Rationale:

Review Hints:

  • Review hints here. Replace this text. Don't use the italics format!

  • Use this optional section to give any relevant information which could help the reviewer to more quickly and assertively understand and test the changes.

  • Good examples are useful commands, if it is better to review all commits together or in a suggested sequence, any relevant discussion in other PRs or issues, etc.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
ansible remediation for rule 'xccdf_org.ssgproject.content_rule_enable_authselect' differs.
--- xccdf_org.ssgproject.content_rule_enable_authselect
+++ xccdf_org.ssgproject.content_rule_enable_authselect
@@ -6,7 +6,7 @@
 
 - name: Enable authselect - Select authselect profile
   ansible.builtin.command:
-    cmd: authselect select "{{ var_authselect_profile }}"
+    cmd: authselect select "{{ var_authselect_profile }}"; echo 1
   register: result_authselect_select
   failed_when: false
   tags:

1 similar comment
Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
ansible remediation for rule 'xccdf_org.ssgproject.content_rule_enable_authselect' differs.
--- xccdf_org.ssgproject.content_rule_enable_authselect
+++ xccdf_org.ssgproject.content_rule_enable_authselect
@@ -6,7 +6,7 @@
 
 - name: Enable authselect - Select authselect profile
   ansible.builtin.command:
-    cmd: authselect select "{{ var_authselect_profile }}"
+    cmd: authselect select "{{ var_authselect_profile }}"; echo 1
   register: result_authselect_select
   failed_when: false
   tags:

Copy link

Change in Ansible shell module found.

Please consider using more suitable Ansible module than shell if possible.

Copy link

Change in Ansible shell module found.

Please consider using more suitable Ansible module than shell if possible.

Copy link

Change in Ansible shell module found.

Please consider using more suitable Ansible module than shell if possible.

@mildas mildas closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant