Move _SixMetaPathImporter to using find_spec() #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.12 seems to have completely done away with find_module(), which the _SixMetaPathImporter still uses. This commit added support for 3.12 through the find_spec() finder approach. Credit: This delta was borrowed from kafka-python project https://github.com/dpkp/kafka-python/blob/master/kafka/vendor/six.py
|
Thanks! I think I'd just drop support of Python2 for good in the next release.. |
|
Makes sense. I'll withdraw this PR then. Thank you. |
|
I guess in the meantime let's use this fix :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.12 seems to have completely done away with find_module(), which the _SixMetaPathImporter still uses. This commit added support for 3.12 through the find_spec() finder approach.
Credits: This delta was borrowed from kafka-python project https://github.com/dpkp/kafka-python/blob/master/kafka/vendor/six.py